Housekeeping #277
Housekeeping #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 9 9
Lines 1025 1025
Branches 216 177 -39
=======================================
Hits 977 977
Misses 44 44
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -155,7 +154,7 @@ def wrapper(decorator): | |||
| # html_theme_options = {} | |||
|
|
|||
| # Add any paths that contain custom themes here, relative to this directory. | |||
| html_theme_path = [sphinx_rtd_theme.get_html_theme_path()] | |||
| # html_theme_path = [] | |||
There was a problem hiding this comment.
You don't mention why to remove this, I think I put it here to match local development to the theme where it is published, in any case it uses a requirement "sphinx_rtd_theme" in docs/requirements.txt, so then that requirement should also be removed.
Sorry to be late, I've been busy with school work but that's all over tomorrow
There was a problem hiding this comment.
It's because of this warning from Sphinx. We are treating warnings as errors.
WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code.
But I think we can leave the dependency because we still have
html_theme = "sphinx_rtd_theme"
I think back in the day the theme loading needed extra help that isn't required anymore. But building locally, with the changes, the docs look the same as on Read the Docs.
There was a problem hiding this comment.
ok, great! Thanks for figuring that out!
A few housekeeping tasks
Termcap.build()csv-tableused for keycodes now requires the deliminator in the header rather than a comma